Skip to content

refactor(setup-encryption-dialog): download key - #17305

Merged
alperozturk96 merged 2 commits into
masterfrom
refactor/setup-encryption-dialog-download-key
Jul 27, 2026
Merged

refactor(setup-encryption-dialog): download key#17305
alperozturk96 merged 2 commits into
masterfrom
refactor/setup-encryption-dialog-download-key

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Adds GeneratePassphraseSendCSR
  • Makes Success non-nullable String

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/28930135320/artifacts/8163506018
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 force-pushed the refactor/setup-encryption-dialog-download-key branch from d05d5c3 to 2654a38 Compare July 22, 2026 07:25
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213213
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4141
Security1919
Total399399

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29900178668/artifacts/8522112223
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
refactor(setup-encryption-dialog): download key
65bbf88 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt
@alperozturk96
wip
0da6f5e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/setup-encryption-dialog-download-key branch from 2654a38 to 0da6f5e Compare July 27, 2026 12:25
@alperozturk96
alperozturk96 merged commit 6c1ba4a into master Jul 27, 2026
16 of 22 checks passed
@alperozturk96
alperozturk96 deleted the refactor/setup-encryption-dialog-download-key branch July 27, 2026 12:28
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/30265881744/artifacts/8653877753
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17305-IT-master-14-26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 35.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96